Re: [PATCH] PCI: Remove MRRS modification from MPS setting code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-09-06 at 12:12 -0700, Jon Mason wrote:
> > Are these typically hitting with the "performance" option ? IE. It
> make
> > sense to leave MRRS untouched in the "safe" case.
> 
> The patch I sent out still used the "performance" option without
> modifying the default MRRS of the device.  All that have tested it
> said that it resolves their issues.

But that will cause other issues as I described, if the MRRS end up
larger than the MPS. IE. The MRRS of a device must be set to be lower or
equal to the MPS of that device (not of the parent btw) if we allow the
parent(s) to have a larger MPS.

I -did- hit a very real problem with adapters where that wasn't true.

As for those users, are they all the same radeon ?

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux