On Tue, 2011-09-06 at 11:11 -0700, Jon Mason wrote: > Yes, that is why I added the MRRS setting code originally. Since the > MRRS setting is almost universally larger than the MPS and some > devices are freaking when their MRRS is changed, we must either use > the "safe" option by default and not touch the MRRS or allow the > "performance" option to have this hole. I suppose a third option is > to create a list of faulty devices that cannot handle MRRS > modification, but that seems rather ugly. Do we know for sure that card can't handle it at all or only freaks out with "0" ? IE Does the card work if MRS == MPS of the card (ie using my algorithm and assuming the host bridge supports arbitrary MPS). > I'm open to any option, but there seems to be a large number of issues > with the MRRS modification code and we need to get a fix into 3.1. Ok, I only head of one, I didn't know there were more. Are these typically hitting with the "performance" option ? IE. It make sense to leave MRRS untouched in the "safe" case. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
