On Mon, Nov 22, 2021 at 9:32 AM Ben Widawsky <ben.widawsky@xxxxxxxxx> wrote: > > On 21-11-22 15:22:24, Jonathan Cameron wrote: > > On Fri, 19 Nov 2021 16:02:34 -0800 > > Ben Widawsky <ben.widawsky@xxxxxxxxx> wrote: > > > > > While the new definitions are yet necessary at this point, they are > > > introduced at this point to help solidify the newly minted schema for > > > naming registers. > > > > > > Signed-off-by: Ben Widawsky <ben.widawsky@xxxxxxxxx> > > > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxx> > > Thanks. I realized on re-reading this I didn't like the commit message. I > reworded to this: > > While the new definitions are not yet necessary at this point, they are > introduced to help solidify the newly minted schema for naming > registers. > > Please let me know if you'd like me to drop your reviewed-by tag. The typical changelog template for patches like this is: "In preparation for adding features X, Y, and Z, add definitions for A, B, and C." Otherwise, patch looks good. Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
