Hi,
[...]
> > Would you be able to move the "10BitTagReq" in the "IOVCtl" after the
> > "Migration" so that its placement is consistent with the "IOVCap"? This
> > would be also along the lines of how the same files is already used in
> > the ls-caps.c file.
>
> To be honest, I am not sure this is suitable.
> PCIe 5.0r1.0 spec section 9.3.3.2 SR-IOV Capabilities Register
> VF 10-Bit Tag Requester Supported defined in BIT[2].
>
> 9.3.3.3 SR-IOV Control Register (Offset 08h)
> VF 10-Bit Tag Requester Enable defined in BIT[5] and this is after the
> BIT[4] ARI Capable Hierarchy.
That makes sense. I have to admit, I didn't think of keeping the order
following which bits are set. That's a nice idea. I see that "DevCap2"
and "DevCtl2" also follow this approach.
> Howerver if we need to keep consistent with the "IOVCap". I can
> move the "10BitTagReq" in the "IOVCtl" after the "Migration".
No need. You are right. It's better to keep it as you originally
intended, make a lot more sense.
Also, thank you for the explanation! Much appreciated.
[...]
> > Bjorn was also working on making a lot of the commas usage throughout to
> > follow the best practice, thus I believe that the commas there would not
> > be needed. Having said that, it might be better to follow the current
> > style present there at the moment.
> >
> > See 018f413 ("lspci: Use commas more consistently") for more details on
> > Bjorn's work to normalise the usage of commas.
>
> Good suggestion, will fix.
Thank you!
> > Additionally, with the new fields, would you also have to update some of
> > the tests files? For example:
> >
> > Index File Line Content
> > 0 tests/cap-dvsec-cxl 81 Capabilities: [b80 v1] Single Root I/O Virtualization (SR-IOV)
> > 1 tests/cap-dvsec-cxl 82 IOVCap: Migration-, Interrupt Message Number: 000
> > 2 tests/cap-dvsec-cxl 83 IOVCtl: Enable- Migration- Interrupt- MSE- ARIHierarchy-
> > 3 tests/cap-dvsec-cxl 84 IOVSta: Migration-
> > 4 tests/cap-pcie-2 50 Capabilities: [160] Single Root I/O Virtualization (SR-IOV)
> > 5 tests/cap-pcie-2 51 IOVCap: Migration-, Interrupt Message Number: 000
> > 6 tests/cap-pcie-2 52 IOVCtl: Enable+ Migration- Interrupt- MSE+ ARIHierarchy-
> > 7 tests/cap-pcie-2 53 IOVSta: Migration-
> > 8 tests/cap-ea-1 59 Capabilities: [180 v1] Single Root I/O Virtualization (SR-IOV)
> > 9 tests/cap-ea-1 60 IOVCap: Migration-, Interrupt Message Number: 000
> > 10 tests/cap-ea-1 61 IOVCtl: Enable+ Migration- Interrupt- MSE+ ARIHierarchy+
> > 11 tests/cap-ea-1 62 IOVSta: Migration-
> >
> OK, will do.
Superb! Thank you!
Krzysztof
