Hi,
[+cc Bjorn who was workingo on making commas usage more consistent]
Thank you for sending the patch over.
> Decode VF 10-Bit Tag Requester Supported and Enable bit
> in SR-IOV Capabilities Register.
>
> Sample output:
> IOVCap: Migration-, 10BitTagReq+, Interrupt Message Number: 000
> IOVCtl: Enable+ Migration- Interrupt- MSE+ ARIHierarchy- 10BitTagReq+
[...]
Would you be able to move the "10BitTagReq" in the "IOVCtl" after the
"Migration" so that its placement is consistent with the "IOVCap"? This
would be also along the lines of how the same files is already used in
the ls-caps.c file.
Bjorn was also working on making a lot of the commas usage throughout to
follow the best practice, thus I believe that the commas there would not
be needed. Having said that, it might be better to follow the current
style present there at the moment.
See 018f413 ("lspci: Use commas more consistently") for more details on
Bjorn's work to normalise the usage of commas.
Additionally, with the new fields, would you also have to update some of
the tests files? For example:
Index File Line Content
0 tests/cap-dvsec-cxl 81 Capabilities: [b80 v1] Single Root I/O Virtualization (SR-IOV)
1 tests/cap-dvsec-cxl 82 IOVCap: Migration-, Interrupt Message Number: 000
2 tests/cap-dvsec-cxl 83 IOVCtl: Enable- Migration- Interrupt- MSE- ARIHierarchy-
3 tests/cap-dvsec-cxl 84 IOVSta: Migration-
4 tests/cap-pcie-2 50 Capabilities: [160] Single Root I/O Virtualization (SR-IOV)
5 tests/cap-pcie-2 51 IOVCap: Migration-, Interrupt Message Number: 000
6 tests/cap-pcie-2 52 IOVCtl: Enable+ Migration- Interrupt- MSE+ ARIHierarchy-
7 tests/cap-pcie-2 53 IOVSta: Migration-
8 tests/cap-ea-1 59 Capabilities: [180 v1] Single Root I/O Virtualization (SR-IOV)
9 tests/cap-ea-1 60 IOVCap: Migration-, Interrupt Message Number: 000
10 tests/cap-ea-1 61 IOVCtl: Enable+ Migration- Interrupt- MSE+ ARIHierarchy+
11 tests/cap-ea-1 62 IOVSta: Migration-
Otheriwse, it looks good! Thank you!
Krzysztof
