On Fri, 2010-05-28 at 06:55 -0500, K, Narendra wrote: > Hello, > > This patch is in continuation of an earlier discussion - > > http://marc.info/?l=linux-netdev&m=126712978908314&w=3 > > The patch has the following review suggestions from the community incorporated - > > 1. The name of the attribute has been changed from "smbiosname" to "label" to hide > the implementation details. > 2. The implementation has been moved to a new file drivers/pci/pci-label.c You've changed the name, which is good, but the implementation is still 100% dependant on ACPI or DMI AFAICS. So it seems to me until it's supported on another platform it may as well go in pci-acpi.c, or at least only be compiled if (ACPI || DMI). Otherwise it's just dead code. cheers
Attachment:
signature.asc
Description: This is a digitally signed message part
