> -----Original Message----- > From: Matt Domsch [mailto:Matt_Domsch@xxxxxxxx] > Sent: Friday, May 28, 2010 11:41 PM > To: Greg KH > Cc: K, Narendra; netdev@xxxxxxxxxxxxxxx; linux-hotplug@xxxxxxxxxxxxxxx; > linux-pci@xxxxxxxxxxxxxxx; Hargrave, Jordan; Rose, Charles; Nijhawan, > Vijay > Subject: Re: [PATCH 1/2] Export firmware assigned labels of network > devices to sysfs > > On Fri, May 28, 2010 at 08:40:41AM -0700, Greg KH wrote: > > On Fri, May 28, 2010 at 06:55:21AM -0500, K, Narendra wrote: > > > +static const char dell_dsm_uuid[] = { > > > > Um, a dell specific uuid in a generic file? What happens when we > need > > to support another manufacturer? > > > > > + 0xD0, 0x37, 0xC9, 0xE5, 0x53, 0x35, 0x7A, 0x4D, > > > + 0x91, 0x17, 0xEA, 0x4D, 0x19, 0xC3, 0x43, 0x4D > > > +}; > > This simply needs to be renamed. It's defined in the ECN, so will be > part of the spec, and is not vendor-unique, but defined once for all > implementations. It separates this _DSM function from others. > > Thanks for the quick feedback. Matt, Thanks for the clarification. My understanding of the uuid was incorrect. Would address this in the next version of the patch. With regards, Narendra K -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
