> -----Original Message----- > From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev- > owner@xxxxxxxxxxxxxxx] On Behalf Of Michael Ellerman > Sent: Monday, May 31, 2010 7:38 PM > To: K, Narendra > Cc: netdev@xxxxxxxxxxxxxxx; linux-hotplug@xxxxxxxxxxxxxxx; linux- > pci@xxxxxxxxxxxxxxx; Domsch, Matt; Hargrave, Jordan; Rose, Charles; > Nijhawan, Vijay > Subject: Re: [PATCH 1/2] Export firmware assigned labels of network > devices to sysfs > > On Fri, 2010-05-28 at 06:55 -0500, K, Narendra wrote: > > Hello, > > > > This patch is in continuation of an earlier discussion - > > > > http://marc.info/?l=linux-netdev&m=126712978908314&w=3 > > > > The patch has the following review suggestions from the community > > incorporated - > > > > 1. The name of the attribute has been changed from "smbiosname" to > > "label" to hide the implementation details. > > 2. The implementation has been moved to a new file > > drivers/pci/pci-label.c > > You've changed the name, which is good, but the implementation is still > 100% dependant on ACPI or DMI AFAICS. > > So it seems to me until it's supported on another platform it may as > well go in pci-acpi.c, You mean the ACPI _DSM ? If yes, it is expected to become a standard very soon. I assume you meant non-Dell platforms by another platform. > or at least only be compiled if (ACPI || DMI). > Otherwise it's just dead code. > Is DMI not implemented widely today ? Please correct me if I am missing something here. With regards, Narendra K ��.n��������+%������w��{.n�����{���"�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
