On Monday 14 September 2009 11:44:39 pm Rolf Eike Beer wrote: > Bjorn Helgaas wrote: > > Convert quirk printks to dev_printk(). > > > > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx> > > CC: Olaf Dabrunz <od@xxxxxxx> > > --- > > drivers/pci/quirks.c | 27 ++++++++++++--------------- > > 1 files changed, 12 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index 85ce239..a77be7a 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -1569,10 +1569,8 @@ static void > > quirk_reroute_to_boot_interrupts_intel(struct pci_dev *dev) return; > > > > dev->irq_reroute_variant = INTEL_IRQ_REROUTE_VARIANT; > > - > > - printk(KERN_INFO "PCI quirk: reroute interrupts for 0x%04x:0x%04x\n", > > - dev->vendor, dev->device); > > - return; > > + dev_info(&dev->dev, "rerouting interrupts for [%04x:%04x]\n", > > + dev->vendor, dev->device); > > } > > I wonder if this [%04x:%04x] isn't redundant, this should be in the device > name of pdev.dev? I did contemplate removing that, because you can always get it with "lspci -nn", but I left it in the interest of being less controversial (look what it got me :-)). But the new printk will look like: pci 0000:40:10.0: rerouting interrupts for [1022:7450] The vendor/device ID doesn't appear in the pdev.dev name, so it's actually not completely redundant. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
