Re: [PATCH] PCI: use dev_printk in quirk messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bjorn Helgaas wrote:
> Convert quirk printks to dev_printk().
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> CC: Olaf Dabrunz <od@xxxxxxx>
> ---
>  drivers/pci/quirks.c |   27 ++++++++++++---------------
>  1 files changed, 12 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 85ce239..a77be7a 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -1569,10 +1569,8 @@ static void
>  quirk_reroute_to_boot_interrupts_intel(struct pci_dev *dev) return;
> 
>  	dev->irq_reroute_variant = INTEL_IRQ_REROUTE_VARIANT;
> -
> -	printk(KERN_INFO "PCI quirk: reroute interrupts for 0x%04x:0x%04x\n",
> -			dev->vendor, dev->device);
> -	return;
> +	dev_info(&dev->dev, "rerouting interrupts for [%04x:%04x]\n",
> +		 dev->vendor, dev->device);
>  }

I wonder if this [%04x:%04x] isn't redundant, this should be in the device 
name of pdev.dev?

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux