Re: [patch 1/6] pci-quirks: unhide 'Overflow' device on i828{6,7}5P/PE chipsets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, February 12, 2009 2:30 am Michał Mirosław wrote:
> On Wed, Feb 11, 2009 at 04:22:29PM -0800, Andrew Morton wrote:
> > On Wed, 11 Feb 2009 23:02:52 +0100
> >
> > Michał Mirosław <mirq-linux@xxxxxxxxxxxx> wrote:
> > > Hello,
> > >
> > > Please use the following version of the patch. This version has shorter
> > > function names and message, and most importantly, better explanation
> > > of problem I encountered.
> > >
> > > [patch starts below]
> > >
> > > Some BIOSes hide 'overflow' device (dev #6) for i82875P/PE chipsets.
> > > The same happens for i82865P/PE. Add a quirk to enable this device.
> > > This allows i82875 EDAC driver to bind to chipset's dev #6 and not
> > > dev #0 as the latter is used by AGP driver.
> > >
> > > On my laptop (i82865P based) ACPI code is disabling this device
> > > again in \_SB.PCI0._CRS method (called at least at PNP init time).
> > > This can be easily worked around by patching DSDT.
> > >
> > > Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
>
> [patch cut]
>
> > Where do we stand with Jesse's earlier comment?
> >
> > On Fri, 9 Jan 2009 13:40:02 -0800
> >
> > Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
> > > This one already got a NAK until Michal can figure out a way to prevent
> > > the SMM code on his machine from hiding this device periodically.
>
> I'm running with this patch since I first created it and after patching
> DSDT the device is not being hidden again. No other bad things happen.
> The biggest concern is that it requires the user to modify ACPI DSDT
> table if the BIOS is hiding the device (ie. Bjorn Helgaas comment).

Yeah, that's my main concern as well, since most users probably won't go so 
far as to patch their DSDTs.  If the quirk defaulted to "off" but could be 
overridden by a boot time parameter it would probably be ok though.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux