On Mon, 1 Dec 2008, Stephen Hemminger wrote: > On Mon, 01 Dec 2008 16:41:15 -0800 > Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> wrote: > > > From: PJ Waskiewicz <peter.p.waskiewicz.jr@xxxxxxxxx> > > > > This patch implements the PCIe Advanced Error Reporting callbacks in > > ixgbe. The 82598 hardware supports AER, so we enable it. > > > > Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@xxxxxxxxx> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> > > --- > > Once again: pcie-aer is not checking for mmconfig working! > If you turn it on, you may get screaming errors. > > pci_enable_pcie_error_reporting should be checking for pci_read/pci_write > config errors and does not. > > Your driver should be checking for pci_enable_pcie_error_reporting failing. I'll respin and have a new patch sent for this. I just finally saw the igb thread, so my apologies for missing this earlier. Cheers, -PJ -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
