On Mon, 1 Dec 2008, David Miller wrote: > From: Stephen Hemminger <shemminger@xxxxxxxxxx> > Date: Mon, 1 Dec 2008 17:47:54 -0800 > > > pci_enable_pcie_error_reporting should be checking for pci_read/pci_write > > config errors and does not. > > > > Your driver should be checking for pci_enable_pcie_error_reporting failing. > > Agreed. I've finally been able to get back to this. I've looked at any other prior use of the PCIe AER routines, and the only driver using it to date is the QLogic QLA2xxx driver in SCSI-land. I've also looked at the return codes, with and without Stephen's recent AER patch, and there's not much the driver can do. If it's catching the errors, the best I can do is print an error message, then continue along. I've put that patch together, and will have it sent along shortly. If there's something additional I'm missing here, please let me know. Cheers, -PJ -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
