Re: [RFC][PATCH] Add sysfs entry that displays MSI-X IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The goal was to expose the IRQs to userspace. The indexes don't matter, just the IRQs. Is there a reason why we would need the indexes? One thing about using indexes though, how would the show function work? I assume the filename would be the index into msi_list. Then each time the show function is executed you walk the list until you hit that index. That would be my way of doing it but it means a spinlock needs to be put in that show function and in msi_free_irqs when walking msi_list. With a binary attribute and it's private pointer or an irq-filename we could avoid that.



Cheers,

-- Vinnie.


Greg KH wrote:
On Fri, Nov 14, 2008 at 01:55:41PM +1100, Michael Ellerman wrote:
On Fri, 2008-11-14 at 12:25 +1100, Vincent Rizza wrote:
Thanks Greg, I wasn't sure what to do there. I've updated it to no permissions.
Would it make more sense to have the filename be the entry_nr, and the
content be the irq?

yes, I thought that was what the original idea was here...
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux