On Thu, Nov 13, 2008 at 12:06:10PM +1100, Vincent Rizza wrote:
> @@ -25,6 +25,19 @@
>
> static int pci_msi_enable = 1;
Your email program seems to be deleting initial spaces ... if you can't
fix this, better send an attachment.
> + * Maximum MSI-X vectors is 2048. Filename will start at
> + * "msix0000" and can go up to "msix2047"
Why put on leading zeroes? is there a problem with 'msix1' instead of
'msix0001'? It'll look less awkward when MSI-Y or MSI-X2 or MSIe come
out supporting 32k interrupts.
On that note, how do people feel about 'msix' as a directory name, and
'msix%d' as filenames? Do we want to be more generic, perhaps
'interrupts' as a directory name, and just %d as a filename?
Also, what about multiple MSI? While it's easy enough to deduce the
interrupt numbers (since they're contiguous), perhaps we should present
them in the same way as MSI-X, so userspace doesn't need to know yet
another special case. (nb, Vincent, this paragraph is not a request to
change anything, just a request for guidance from the hivemind).
> + entry->sysfs_entry.attr.name = (const char *)
> entry->msix_fname;
Your email program is also wrapping this, which is suboptimal.
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index c75b82b..6b818f7 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -234,6 +234,7 @@ struct pci_dev {
> struct bin_attribute *res_attr_wc[DEVICE_COUNT_RESOURCE]; /* sysfs
> file for WC mapping of resources */
> #ifdef CONFIG_PCI_MSI
> struct list_head msi_list;
> + struct kobject *msix_dir;
> #endif
> struct pci_vpd *vpd;
> };
Eeek. I dislike growing pci_dev ... but I think it's best to let this
one go for now. I have a plan in my head for 'struct msi' with a more
efficient representation of the vectors, but that's a conversation for
another time, and I can fix this up then.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
