Re: [RFC][PATCH] Add sysfs entry that displays MSI-X IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 13, 2008 at 12:06:10PM +1100, Vincent Rizza wrote:
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -2,6 +2,7 @@
> #define LINUX_MSI_H
> #include <linux/list.h>
> +#include <linux/kobject.h>
> struct msi_msg {
> 	u32	address_lo;	/* low 32 bits of msi message address */
> @@ -33,6 +34,10 @@ struct msi_desc {
> 	void __iomem *mask_base;
> 	struct pci_dev *dev;
> +	struct	bin_attribute sysfs_entry;

Why are you using a binary sysfs file?  Those are only for binary files
(firmware, raw config data, etc.), not plain text files like these.

Please fix this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux