On Fri, Nov 14, 2008 at 11:40:09AM +1100, Vincent Rizza wrote: > Hi again, > Made a few changes based on the feedback. A binary file isn't used anymore. > The directory name has changed to reflect exactly what it's displaying. > Naming it "interrupts" seemed a little incorrect in this instance since > it's only displaying MSI-X interrupts. I have no problem changing the > directory name though. The IRQs are now represented by naming each file the > IRQ value. The reason for the change was simple, it removed the need for > any type of show function or special attribute and does away with the msix > prefix since we know it's msix from the directory name. > > > Cheers, > > > -- Vinnie. > >From 04b1059375ce146f6d12ac15e183e8d1187f10ce Mon Sep 17 00:00:00 2001 > From: Vincent Rizza <vinnie@xxxxxxx> > Date: Thu, 13 Nov 2008 10:27:33 +1100 > Subject: [RFC][PATCH] Add sysfs entry that displays MSI-X IRQs > > Here's the new patch. It creates an "msix_irq" directory in > /sys/bus/pci/devices/.../ and populates it with a file for each MSI-X > vector used by the device. The filename is the vector number(ie. IRQ). > > Exposing the vectors to userspace allows applications like > irqbalancer to intelligently spread device IRQs across many CPUs > since it will be able to work out which IRQ belongs to which device. > > Signed-off-by: Vincent Rizza <vinnie@xxxxxxx> > Signed-off-by: Brett Grandbois <brettg@xxxxxxx> > Signed-off-by: Greg Banks <gnb@xxxxxxx> > --- > Documentation/ABI/testing/sysfs-bus-pci | 9 +++++++ > drivers/pci/msi.c | 38 +++++++++++++++++++++++++++++++ > include/linux/msi.h | 5 ++++ > include/linux/pci.h | 1 + > 4 files changed, 53 insertions(+), 0 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci > index ceddcff..4f6f038 100644 > --- a/Documentation/ABI/testing/sysfs-bus-pci > +++ b/Documentation/ABI/testing/sysfs-bus-pci > @@ -9,3 +9,12 @@ Description: > that some devices may have malformatted data. If the > underlying VPD has a writable section then the > corresponding section of this file will be writable. > + > +What: /sys/bus/pci/devices/.../msix_irq/<IRQ vector number> > +Date: November 2008 > +Contact: Vincent Rizza <vinnie@xxxxxxx> > +Description: > + If a pci device uses any MSI-X IRQs a new directory > + is created called "msix_irq". The directory contains a > + file for each MSI-X IRQ used. The filename is the IRQ > + number. What are the contents of these files? You are saying it is readable, but if there is nothing in there, that's going to confuse a lot of people :( thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
