On Wed, Aug 21, 2013 at 10:51:16AM +0530, Lokesh Vutla wrote: > Hi Olof, > On Tuesday 20 August 2013 11:37 PM, Olof Johansson wrote: > > The newly added omap4 support in the driver was added without > > consideration for building older configs. When building omap1_defconfig, > > it resulted in: > > > > drivers/char/hw_random/omap-rng.c:190:12: warning: 'omap4_rng_init' defined but not used [-Wunused-function] > > drivers/char/hw_random/omap-rng.c:215:13: warning: 'omap4_rng_cleanup' defined but not used [-Wunused-function] > > drivers/char/hw_random/omap-rng.c:251:20: warning: 'omap4_rng_irq' defined but not used [-Wunused-function] > > > > Move the code around so it is grouped with its operations struct, which > > for the omap4 case means also under the #ifdef CONFIG_OF, where it needs > > to be. > > > Missed testing this. Thanks for the patch. > Reviewed-by: Lokesh Vutla <lokeshvutla@xxxxxx> Patch applied. Thanks! -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
