Re: [PATCHv3 1/9] memory: emif: Move EMIF register defines to include/linux/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 12 August 2013 03:32 PM, Greg Kroah-Hartman wrote:
> On Thu, Aug 08, 2013 at 09:35:46AM -0400, Santosh Shilimkar wrote:
>> (You have not CC'ed Greg, Looping him)
>>
>> On Tuesday 06 August 2013 01:49 PM, Dave Gerlach wrote:
>>> OMAP4 and AM33XX share the same EMIF controller IP. Although there
>>> are significant differences in the IP integration due to which
>>> AM33XX can't reuse the EMIF driver DVFS similar to OMAP4,
>>> it can definitely benefit by reusing the EMIF related macros
>>> defined in drivers/memory/emif.h.
>>>
>>> In the current OMAP PM framework the PM code resides under
>>> arch/arm/mach-omap2/. To enable reuse of the register defines move
>>> the register defines in the emif header file to include/linux so that
>>> both the EMIF driver and the AM33XX PM code can benefit.
>>>
>>> Signed-off-by: Dave Gerlach <d-gerlach@xxxxxx>
>>> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>>> Cc: Benoit Cousson <benoit.cousson@xxxxxxxxxx>
>>> Cc: Aneesh V <aneesh@xxxxxx>
>>> ---
>>>  drivers/memory/emif.h   |  543 +--------------------------------------------
>>>  include/linux/ti_emif.h |  558 +++++++++++++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 559 insertions(+), 542 deletions(-)
>>>  create mode 100644 include/linux/ti_emif.h
>>>
>> For file movement or some part of file movement, while formating
>> patch, use "git format-patch -C" so that only delta change will
>> appear in the patch.
>>
>> The patch as such is fine by me.
>> Acked-by: Santosh Shililmar <santosh.shilimkar@xxxxxx>
>>
>> Greg,
>> Your ack is needed on this patch so that it can go
>> along with the series. Subsequent patch from this series
>> use the register defines from this patch.
> 
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
Thanks !!
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux