Hi, On Tue, Jul 09, 2013 at 04:51:35PM +0530, George Cherian wrote: > >>+ compatible = "snps,dwc3"; > >>+ reg = <0x48390000 0xcfff>; > >weird size, shouldn't this be 0xd000 then the size would be exactly > >52KiB > > okay btw, the reason here is that when you call devm_ioremap_resource(), that will call resource_size() which does: size = res->end - res->start - 1; so you need this extra 1 on the size when passing it via DT. > >Another thing: am437x has 4 instances of this IP, why are you adding > >only one ? > > AM437x has got only 2 instances. I have verified only one on HAPS so > adding only one. weird, on my TRM I see for dwc3 but 2 PHYs. > >And why aren't you pasing the PHY nodes here ? The device > >won't work without its PHYs. > > Yes true, again in HAPS I didnt have any PHY configuration to be done. alright, but we should still pass the PHY right ? once silicon comes, we want this to work without any further changers. -- balbi
Attachment:
signature.asc
Description: Digital signature
