On Tue, Jul 09, 2013 at 02:47:26PM +0530, George Cherian wrote:
> Adds device node for HS USB Host module for AM437x
>
> changes from v1
>
> renamed synopsis to snps
> removed flag tx-fifo-resize
the patch revision changes don't need to go to the commit log,
they should be placed after the tearline (---) and before the diffstat.
> Signed-off-by: George Cherian <george.cherian@xxxxxx>
> ---
> arch/arm/boot/dts/am4372.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index ddc1df7..c9e0da8 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -64,5 +64,23 @@
> compatible = "ti,am4372-counter32k","ti,omap-counter32k";
> reg = <0x44e86000 0x40>;
> };
> +
> + usb_otg_hs1: am4372_dwc3@48380000 {
dtsi should always have status = "disabled"; no ?
> + compatible = "ti,am437x-dwc3";
> + reg = <0x48380000 0x1ff>;
weird size, shouldn't this be 0x200 ?
> + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + utmi-mode = <1>;
> + ranges;
> +
> + dwc3@48390000 {
dtsi should always have status = "disabled"; no ?
> + compatible = "snps,dwc3";
> + reg = <0x48390000 0xcfff>;
weird size, shouldn't this be 0xd000 then the size would be exactly
52KiB
> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + };
> +
there two trailing tabs on this line.
Another thing: am437x has 4 instances of this IP, why are you adding
only one ? And why aren't you pasing the PHY nodes here ? The device
won't work without its PHYs.
--
balbi
Attachment:
signature.asc
Description: Digital signature
