On Thu, 4 Jul 2013, Rajendra Nayak wrote: > Paul/Benoit, > > Should I also drop these lines from the file headers since they are no > longer same as the outputs from autogen files? > > * This file is automatically generated from the OMAP hardware databases. > * We respectfully ask that any modifications to this file be coordinated > * with the public linux-omap@xxxxxxxxxxxxxxx mailing list and the > * authors above to ensure that the autogeneration scripts are kept > * up-to-date with the file contents. Heh... Here's my view: You mentioned that these patches were generated with some kind of awk/grep scripting. Can you integrate that in an automated way into the autogeneration flow? If the answer is yes, then keep the header. If the answer is no, then the header should be dropped. Benoît, maybe you have an opinion too? As far as whether this should go in -rcX or not, my view is that, as a matter of policy, large changes like this should wait until v3.12. Now, having written that, I also was under the impression that the OMAP5 changes weren't going to be sent upstream unless the total diffstat would be balanced to roughly zero or negative lines. As far as I know, that didn't happen. So I guess, v3.11-rc it is... kernel development by diffstat :-( Finally, please repost the whole series once you're done with your changes, as a non-RFC, along with your pull request (if you plan to send one). I guess I should be the one to take these, since I wound up taking the OMAP5 addition... regards - Paul
