On 06/11/2013 04:23 PM, Samuel Ortiz wrote: > Hi Sebastian, Hi Samuel, > On Tue, Jun 11, 2013 at 01:30:56PM +0200, Sebastian Andrzej Siewior wrote: >> From: "Patil, Rachna" <rachna@xxxxxx> >> >> Make changes to add DT support in the MFD core driver. > Which changes ? So rewrite the commit log… >> [ panto@xxxxxxxxxxxxxxxxxxxxxxx : use of_get_child_by_name >> instead of of_find_node_by_name ] > I have no idea where that is coming from. Please remove this kind of > stuff and build a proper commit log instead. > > >> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Patil, Rachna <rachna@xxxxxx> >> Signed-off-by: Felipe Balbi <balbi@xxxxxx> >> [bigeasy: module alias, rename to ti,am3359-tscadc as it was tested on >> AM3359] > I honestly can't tell if this is a change from the last version of your > patchset or a description of this patch changes in general. > This is cluttering your commit logs, please remove this as well. I took the original patch. Every change I made to it because people asked to merge changes into the patch where the problem occurred I added it here before my sign-off. In the end I would like not to post a patch with "From: != me" and don't make change which the original author did not do. Also dropping their authorship isn't nice. What could we agree on? > Cheers, > Samuel. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html