On Tue, Apr 09, 2013 at 09:40:04AM -0700, Tony Lindgren wrote: [...] > But then the regulator is not found and the driver should just exit, > or do nothing. If this is an optional regulator, then that should be > indicated in some platform data flags? Yes, if the regulator isn't found then the driver fails. However the goal was to maintain bisectability. If we apply them in the wrong order we can't guarantee that because pwm-backlight will fail to work between both patches. > The driver parts really must be done in independently from any platform > data or .dts changes. The only common part needed should be changes > to include/linux/platform_data/*.h files. We don't even need to touch platform data because the regulators are looked up via a global table. And the changes are all done independently but as I mentioned above, bisectability isn't maintained, so the preferred patch order is the one in which pwm-backlight keeps working at each point in the commit history. Thierry
Attachment:
pgpEKtBVb2gBD.pgp
Description: PGP signature
