Re: [PATCH V3 1/2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> [130408 15:01]:
> On Mon, Apr 08, 2013 at 02:46:24PM -0700, Tony Lindgren wrote:
> > * Andrew Chew <achew@xxxxxxxxxx> [130313 15:37]:
> > > The pwm-backlight driver now takes a mandatory regulator that is gotten
> > > during driver probe.  Initialize a dummy regulator to satisfy this
> > > requirement.
> > > 
> > > Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>
> > > ---
> > > Changed the device name of the backlight regulator supply to "pwm-backlight",
> > > per Peter's comment.
> > > 
> > > Changed the name of the regulator to "backlight-enable", per Thierry's
> > > suggestion.
> > 
> > Thanks applying into omap-for-v3.10/board. Note that I'm not taking the
> > second one, that should be resent to the related driver maintainers.
> > You can get that list by running scripts/get_maintainer.pl against it.
> 
> The plan was to take these all through one tree, preferably the PWM tree
> because it's all PWM related and the pwm-backlight change will go
> through that tree as well. Technically these individual patches can be
> applied as is and aren't harmful, but keeping track of the dependencies
> might be difficult if they go in via separate trees.

Registering the regulator alone should not do anything. Also the driver
should do the right thing if the regulator is not yet registered.

Can you please check your driver patch so the driver won't do anything
if the regulator is not (yet) registered and repost it alone as I've
already applied the board-*.c change.

The reason why we want to do queue these patches separately is to cut
away the dependency between drivers and the core arch/arm changes. 
Otherwise we'll end up with pointless merge conflicts as we've seen
earlier several times with the USB patches for example.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux