On Tue, Mar 12, 2013 at 12:11:54PM -0700, Andrew Chew wrote: > > From: Thierry Reding [mailto:thierry.reding@xxxxxxxxxxxxxxxxx] > > Sent: Tuesday, March 12, 2013 12:01 AM > > To: Andrew Chew > > Cc: peter.ujfalusi@xxxxxx; Alex Courbot; linux-omap@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/1] ARM: OMAP: board-4430sdp: Provide regulator to > > pwm-backlight > > > > * PGP Signed by an unknown key > > > > On Mon, Mar 11, 2013 at 06:54:26PM -0700, Andrew Chew wrote: > > > The pwm-backlight driver now takes a mandatory regulator that is > > > gotten during driver probe. Initialize a dummy regulator to satisfy > > > this requirement. > > > > > > Signed-off-by: Andrew Chew <achew@xxxxxxxxxx> > > > --- > > > This patch, along with many more soon to follow, attempts to satisfy > > > the new mandatory regulator that pwm-backlight will grab during probe. > > > The only board in mach-omap2 to use the pwm-backlight appears to be the > > 4430sdp. > > > > > > I thought I'd start small and use this board as an example. > > > > > > I tested similar code in my Tegra board, so it should be okay. Of > > > course, I don't have a 4430sdp to test with. > > > > Hi Andrew, > > > > This looks good, one minor comment below. I think it might make sense to > > post this patch as part of a series that includes the change to the pwm- > > backlight driver. This will make things easier on potential testers. > > You can later extend that series to include all the other users and eventually > > the whole series can be merged. > > Do you mean I should do a single patch series, accumulating other boards > as I go? Yes, that way everything needed will be in one patch series and people can easily apply that to their trees. It will also make things easier if we decide to merge all of them through one tree in the end. > And by the way, do I have your reviewed-by for the pwm-backlight regulator > patch? I think it looks good, but I'll go over it again in your repost of the whole series. I don't think you need my Reviewed-by, though, since I maintain the pwm-backlight driver. =) Thierry
Attachment:
pgpEEvKGQZbRW.pgp
Description: PGP signature
