Hi,
On 03/12/2013 02:54 AM, Andrew Chew wrote:
> The pwm-backlight driver now takes a mandatory regulator that is gotten
> during driver probe. Initialize a dummy regulator to satisfy this
> requirement.
Can you point me to the commit which makes a regulator mandatory for
pwm-backlight?
Why the regulator is mandatory?
The 4430SDP (or Blaze) and Zoom2 is just happy alone with the PWM why should
we have dummy regulators?
>
> Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>
> ---
> This patch, along with many more soon to follow, attempts to satisfy the new
> mandatory regulator that pwm-backlight will grab during probe. The only
> board in mach-omap2 to use the pwm-backlight appears to be the 4430sdp.
>
> I thought I'd start small and use this board as an example.
>
> I tested similar code in my Tegra board, so it should be okay. Of course,
> I don't have a 4430sdp to test with.
>
> arch/arm/mach-omap2/board-4430sdp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index 35f3ad0..62022c0 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -291,6 +291,10 @@ static struct platform_device sdp4430_leds_pwm = {
> },
> };
>
> +/* Dummy regulator for pwm-backlight driver */
> +static struct regulator_consumer_supply backlight_supply =
> + REGULATOR_SUPPLY("enable", NULL);
> +
> static struct platform_pwm_backlight_data sdp4430_backlight_data = {
> .max_brightness = 127,
> .dft_brightness = 127,
> @@ -718,6 +722,7 @@ static void __init omap_4430sdp_init(void)
>
> omap4_i2c_init();
> omap_sfh7741prox_init();
> + regulator_register_always_on(-1, "bl-enable", &backlight_supply, 1, 0);
> platform_add_devices(sdp4430_devices, ARRAY_SIZE(sdp4430_devices));
> omap_serial_init();
> omap_sdrc_init(NULL, NULL);
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
