> From: Thierry Reding [mailto:thierry.reding@xxxxxxxxxxxxxxxxx] > Sent: Tuesday, March 12, 2013 12:01 AM > To: Andrew Chew > Cc: peter.ujfalusi@xxxxxx; Alex Courbot; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/1] ARM: OMAP: board-4430sdp: Provide regulator to > pwm-backlight > > * PGP Signed by an unknown key > > On Mon, Mar 11, 2013 at 06:54:26PM -0700, Andrew Chew wrote: > > The pwm-backlight driver now takes a mandatory regulator that is > > gotten during driver probe. Initialize a dummy regulator to satisfy > > this requirement. > > > > Signed-off-by: Andrew Chew <achew@xxxxxxxxxx> > > --- > > This patch, along with many more soon to follow, attempts to satisfy > > the new mandatory regulator that pwm-backlight will grab during probe. > > The only board in mach-omap2 to use the pwm-backlight appears to be the > 4430sdp. > > > > I thought I'd start small and use this board as an example. > > > > I tested similar code in my Tegra board, so it should be okay. Of > > course, I don't have a 4430sdp to test with. > > Hi Andrew, > > This looks good, one minor comment below. I think it might make sense to > post this patch as part of a series that includes the change to the pwm- > backlight driver. This will make things easier on potential testers. > You can later extend that series to include all the other users and eventually > the whole series can be merged. Do you mean I should do a single patch series, accumulating other boards as I go? And by the way, do I have your reviewed-by for the pwm-backlight regulator patch? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
