On 03/01/2013 11:30 AM, Russell King - ARM Linux wrote: > On Fri, Mar 01, 2013 at 05:17:57PM +0100, Javier Martinez Canillas wrote: >>>> unsigned long irq_flags = SMC_IRQ_FLAGS; >>>> ... >>>> if (irq_flags == -1 || ires->flags & IRQF_TRIGGER_MASK) >>>> irq_flags = ires->flags & IRQF_TRIGGER_MASK; >>>> >>>> while smsc911x driver's probe function uses the flags from the >>>> resource unconditionally: >>>> >>>> irq_flags = irq_res->flags & IRQF_TRIGGER_MASK; >>>> >>>> So, at the end both will set irq_flags to whatever is on the >>>> IORESOURCE_IRQ struct resource flags member. >>> >>> Actually, that's not the case for smc91x. By default SMC_IRQ_FLAGS != -1 >>> (for omap) and so it will not set irq_flags to ires->flags & >>> IRQF_TRIGGER_MASK. However, if I force irq_flags to be -1, then I see >>> that irq_flags are to 0. > > smc91x is complicated by the fact that it started off life before there > was any possibility to pass IRQ flags through resources. So we ended > up with smc91x.h containing _lots_ of platform specific data, and the > driver could only be built for one platform. > > I fixed that by sorting out this IRQ passing method, and changing smc91x > to support both the fixed configuration, and the dynamic-through-IRQflags > method. > > There is no reason for any other driver to support the fixed method; that > would be a completely backwards step. Thanks for the history. For OMAP I see SMC_IRQ_FLAGS getting defined as follows in smc91x.h ... #ifndef SMC_IRQ_FLAGS #define SMC_IRQ_FLAGS IRQF_TRIGGER_RISING #endif And so for OMAP devices using smc91x, it is always being configured as rising-edge. So it would be good to move OMAP to use a dynamic configuration too. Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
