On 03/01/2013 02:12 PM, Ezequiel Garcia wrote: > On Fri, Mar 1, 2013 at 5:11 PM, Ezequiel Garcia <elezegarcia@xxxxxxxxx> wrote: >> Hi Jon, >> >> On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter <jon-hunter@xxxxxx> wrote: >> [...] >>> >>> + if (!of_property_read_u32(np, "gpmc,bus-turnaround", &val)) >>> + gpmc_t->bus_turnaround = val; >>> + >> >> AFAIK, you don't need to test if the property is defined. >> You can just read it straightforward, and if the property is not defined >> then nothing will be stored in your variable: >> >> of_property_read_u32(np, "gpmc,bus-turnaround", &gpmc_t->bus_turnaround); >> >> You can simplify *a lot* your patch with this, and I believe you could >> also clean >> existent code. >> > > Also, since this is somewhat large patchset: would you mind pushing it somewhere > so I can just pull a branch? See link in cover-letter ;-) Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
