On Tue, Feb 05, 2013 at 10:44:05AM +0200, Roger Quadros wrote:
> >> diff --git a/include/linux/usb/nop-usb-xceiv.h b/include/linux/usb/nop-usb-xceiv.h
> >> index 3265b61..148d351 100644
> >> --- a/include/linux/usb/nop-usb-xceiv.h
> >> +++ b/include/linux/usb/nop-usb-xceiv.h
> >> @@ -6,6 +6,10 @@
> >> struct nop_usb_xceiv_platform_data {
> >> enum usb_phy_type type;
> >> unsigned long clk_rate;
> >> +
> >> + /* if set fails with -EPROBE_DEFER if can't get regulator */
> >> + unsigned int needs_vcc:1;
> >> + unsigned int needs_reset:1;
> >
> > how about u8 here?
>
> Not sure. Bitfields are usually defined as unsigned int.
IIRC the benefit is that compiler can try to optimize those flags. I
mean, if you have 32 1-bit flags, compiler will combine those in a
single u32. Someone correct me if I'm wrong.
after you fix other comments from kishon (about of_read_bool()), you can
add my:
Acked-by: Felipe Balbi <balbi@xxxxxx>
--
balbi
Attachment:
signature.asc
Description: Digital signature
