On Thu, Sep 20, 2012 at 11:32:12AM +0100, Lorenzo Pieralisi wrote: > On Wed, Sep 19, 2012 at 02:51:56PM +0100, Dave Martin wrote: > > On Tue, Sep 18, 2012 at 05:35:32PM +0100, Lorenzo Pieralisi wrote: > > > This patch renames jump labels in v7_flush_dcache_all in order to define > > > a specific flush cache levels entry point. > > > > > > TODO: factor out the level flushing loop if considered worthwhile and > > > define the input registers requirements. > > > > In the context of this series, this patch seems to do nothing at all (?) > > Agreed, it is just replacing some labels. I thought that something like: > > b flush_levels > > is clearer than: > > b loop1 > > If I manage to factor out the cache level flushing loop I think things > are even better, I just did not want to change v7_flush_dcache_all, I would > avoid doing that, unless, as I mentioned, it is considered worthwhile. > > > Maybe it would make sense to defer this patch until you post something > > that uses it. > > v7_flush_dcache_louis uses it, I have no problem in deferring it though. I don't think it's necessary to defer it -- I just wanted to understand whether there was some context here I wasn't aware of. Cheers ---Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
