On Wed, Sep 19, 2012 at 11:08:13PM +0300, Aaro Koskinen wrote: > On Fri, Sep 14, 2012 at 12:08:06PM +0200, Wolfram Sang wrote: > > On Mon, Sep 03, 2012 at 11:23:22PM +0300, Aaro Koskinen wrote: > > > Add i2c driver to enable access to devices behind CBUS on Nokia Internet > > > Tablets. > > > > > > The patch also adds CBUS I2C configuration for N8x0 which is one of the > > > users of this driver. > > > > > > Cc: linux-i2c@xxxxxxxxxxxxxxx > > > Acked-by: Felipe Balbi <balbi@xxxxxx> > > > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> > > > Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx> > > > > OK, I found the short paragrahp about CBUS in the I2C spec, so I2C might > > be an appropriate place. Still, before deciding if it should rather be > > in the core directory, I still have a few questions. > > Thanks for your feedback. I will fix up the incorrect comments, and do > other improvements (e.g. use devm_* stuff) in the next version. > > The questions about delays and bit counts are very valid, but it's > difficult to do anything with them due to lack of documentation and HW on > which to test - I have Nokia tablets to test the driver, and the driver > is very reliable, but I do not know of any other HW with CBUS. :-/ Fine enough, then please add comments saying that. -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
