On Thu, Sep 13, 2012 at 6:38 PM, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Thu, Sep 13, 2012 at 06:31:35PM +0530, Shilimkar, Santosh wrote: >> In the series, there is patch "[PATCH 3/6]" which adds an >> API which let you operate on a specific level. > > Which is introduced but as far as I can see, is never used in the patch > set. Therefore, it shouldn't be introduced. > > We've been here before many many many times, where people introduce stuff > into the kernel, and then they never get around to using the damned stuff. > It's happened far too many times to permit on a "but I will use it in the > future" kind of arguments. > > If you're going to introduce something new, include the users in the patch > set, or don't bother submitting the new function in the vague hope that > some day it will get used. Fair enough. We can postpone adding that API now in this series and add it along with the user. For the record, it was added to use in the A15 low power code to operate on L1 and L2 levels based on the power domain states. Regards santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
