On Fri, 2012-07-27 at 12:55 -0700, Kevin Hilman wrote: > Tero Kristo <t-kristo@xxxxxx> writes: > > > Voltdm, pwrdm, clkdm, hwmod and clk usecounts are now separeted to > > their own file, 'usecount'. This file shows the usecounts for every > > active domain and their children recursively. 'count' file now only > > shows power state counts for powerdomains. > > > > This patch also provices a way to do printk dumps from kernel code, > > by calling the pm_dbg_dump_X functions. The plan is to call these > > functions once an error condition is detected, e.g. failed suspend. > > > > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > > Cc: Paul Walmsley <paul@xxxxxxxxx> > > Cc: Kevin Hilman <khilman@xxxxxx> > > I think we should separate out the debug stuff as a separate patch set. > > Where I want to go with PM debug is away from in-kernel debug prints and > towards using tracepoints. We have tracepoints in the clock code that > correspond to usecounts, but we need them in the clkdm, pwrdm and voltdm > code as well. With that, you can use userspace tools (perf, ftrace) to > trace a problem (e.g. failed suspend) and see voltdm/pwrdm/clkdm/clks > are on when they shouldn't be. Yes, I can split out the debug stuff from this set for next rev. I'll also take a look at the tracepoints if they can be used reasonably for this purpose. We can add tracepoints for failed suspend for each powerdomain, but are tracepoints a good way to do this kind of recursive dumps (well, we could maybe register a trace event recursively from clkdm + clk code if a powerdomain fails to transition.) -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
