On 27 June 2012 13:43, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > > I don't like it at all that omapdss disables and enables the panels in > omapdss's suspend/resume hooks. But I'm not sure how this should work... > Should panel drivers each have their own suspend/resume hooks, and > handle it themselves? Or should the call to suspend/resume come from > upper layers, like omapfb or omapdrm. > > I made a prototype patch a few weeks ago to move the suspend to omapfb, > and it feels better than the current one, but I'm still not sure... > IIUC, I have similar opinion. Each panel having its own suspend/resume sounds like inter-dependency trouble. I too would prefer suspend/resume propagating from omap-fb/drm, which imho fits better with the notion of a linux device(omapdss is only backend). Though I don't have strong feelings about how core then take various panels up/down optimally. BR. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html