On Mon, 2012-06-25 at 14:19 +0530, Jassi Brar wrote: > On 25 June 2012 11:50, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > > On Sat, 2012-06-23 at 13:36 +0530, jaswinder.singh@xxxxxxxxxx wrote: > .... > >> Currenlty HDMI fails to come up in the suspend-resume path. > >> This patch helps that real-world scenario. > > > > What is the problem there? It'd be good to explain the problem in the > > patch description. Does the pm_runtime_get return -EACCES? > > > Yes, it returns -EACCESS because RPM on devices is disabled during the > period from suspend-start to resume-finished. So... You didn't answer my first comment, how can the code work? The driver needs to enable the HW and the call to pm_runtime_get() is skipped. Won't this lead to crash as the DSS registers are accessed without the HW in enabled state? And what happens if the pm_runtime_get() call is skipped, but pm_runtime_put() is not? Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
