On Tue, 2012-06-26 at 20:39 +0530, Jassi Brar wrote: > On 26 June 2012 20:38, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > > On Tue, 2012-06-26 at 20:19 +0530, Jassi Brar wrote: > >> On 26 June 2012 17:33, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > >> > On Tue, 2012-06-26 at 15:27 +0530, Jassi Brar wrote: > >> > > >> >> Seems similar, but I only tested OMAP4 HDMI. > >> > > >> > Would something like this one below work for you? It fixes the issues on > >> > my overo board. > >> > > >> I think this should work too (I will get to test it only tomorrow). > >> > >> Though I don't think it'll fix stack spew when run without > >> CONFIG_PM_RUNTIME. Maybe we could simply remove the WARN_ON in the > >> xxx_runtime_put() as Alan noted? > > > > Yes, that's a different issue. I'll look at that also. > > > Well, my patch took care of that also. But I agree, that could be > added separately as well. Well, I don't agree that your patch is correct =). I don't think it's right to skip runtime get and put when pm_runtime_enabled() returns false. Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
