Re: [PATCH v2] OMAP: igep0020: fix smsc911x dummy regulator id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Enrico Butera <ebutera@xxxxxxxxxxxxxxxxxxxxx> [120509 02:32]:
> From: Enrico Butera <ebutera@xxxxxxxxxxxxxxxx>
> 
> id 0 is already used and causes errors at boot:
> 
> WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
> sysfs: cannot create duplicate filename '/devices/platform/reg-fixed-voltage.0'
> 
> Fix it by using the next available one (id=1).

Thanks adding into fixes with updated comments for the regression,
updated patch below.

Tony


From: Enrico Butera <ebutera@xxxxxxxxxxxxxxxx>
Date: Wed, 9 May 2012 11:27:59 +0200
Subject: [PATCH] ARM: OMAP: igep0020: fix smsc911x dummy regulator id

id 0 is already used and causes errors at boot:

WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
sysfs: cannot create duplicate filename '/devices/platform/reg-fixed-voltage.0'

Fix it by using the next available one (id=1).

This was caused by 5b3689f4 (ARM: OMAP2+: smsc911x: Add fixed
board regulators) that did not account for some regulators
already being used.

Signed-off-by: Enrico Butera <ebutera@xxxxxxxxxxxxxxxx>
[tony@xxxxxxxxxxx: updated comments for regression causing commit]
Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
index 930c0d3..740cee9 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -641,7 +641,7 @@ static struct regulator_consumer_supply dummy_supplies[] = {
 
 static void __init igep_init(void)
 {
-	regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
+	regulator_register_fixed(1, dummy_supplies, ARRAY_SIZE(dummy_supplies));
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
 
 	/* Get IGEP2 hardware revision */
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux