* Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [120509 04:09]: > Hi Olof, > > On Tuesday 08 May 2012 23:48:06 Olof Johansson wrote: > > Hi, > > > > On Mon, May 7, 2012 at 3:36 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > The following changes since commit > 69964ea4c7b68c9399f7977aa5b9aa6539a6a98a: > > [..] > > > > > Enrico Butera (1): > > > ARM: OMAP: igep0020: fix smsc911x dummy regulator id > > > > Hmm. Picking 40 without any kind of comment in the code isn't doing > > any favors for future readers. Seems like 1 would be free on this > > board, from the rest of the board file to judge (one other > > reg-fixed-regulator platform device)? > > > > Please either comment why you picked 40 (i.e. it's a random number), > > or change it to something a little less random like 1. :) I'll use the update patch from Enrico. > > > Laurent Pinchart (1): > > > ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally > > > > Is this a regression? I don't see any recent changes regarding this, > > so it's hard to tell. If not then I'd rather hold off for the merge > > window given that we're at -rc6. > > It's not a regression, I'm fine with holding off until the v3.5 merge window. And will move this one into fixes-non-critical. Will send a new pull request shortly. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
