Hi Paul,
On Mon, May 07, 2012 at 16:42:16, Mohammed, Afzal wrote:
> > > +static struct omap_hwmod omap3xxx_gpmc_hwmod = {
> > > + .name = "gpmc",
> > > + .class = &omap3xxx_gpmc_hwmod_class,
> > > + .clkdm_name = "l3_init_clkdm",
> > > + .mpu_irqs = omap3xxx_gpmc_irqs,
> > > + .main_clk = "gpmc_fck",
> > > + .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> > > +};
> >
> > Is there some reason why you are setting the HWMOD_INIT_NO_RESET flag
> > here? Seems to me that the kernel should not rely on the bootloader GPMC
> > configuration, but should use a configuration from the board file or DT.
>
>
> Major reason was that there are some boards that rely on bootloader
> settings, eg. kernel does not do any setting for smsc911x. I did not
> want to break those, at least it causes problem with omap3evm
If HWMOD_NO_INIT_RESET is not present, it would break GPMC on
many of the existing boards.
New version of GPMC HWMOD patch has been posted with HWMOD_NO_IDLEST flag,
which is a squashed one with OMAP2xxx HWMOD
Regards
AFzal
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
