Hello Afzal
a few comments
On Wed, 2 May 2012, Afzal Mohammed wrote:
> Add gpmc hwmod and associated interconnect data
>
> Signed-off-by: Afzal Mohammed <afzal@xxxxxx>
Did you notice the warning that this patch generates on boot?
omap_hwmod: gpmc: cannot be enabled for reset (3)
The HWMOD_NO_IDLEST hwmod flag is needed, since there is no GPMC IDLEST
bit.
...
Also, the OMAP2xxx GPMC hwmod data is missing. It can be combined
with this patch.
...
Also:
> +static struct omap_hwmod omap3xxx_gpmc_hwmod = {
> + .name = "gpmc",
> + .class = &omap3xxx_gpmc_hwmod_class,
> + .clkdm_name = "l3_init_clkdm",
> + .mpu_irqs = omap3xxx_gpmc_irqs,
> + .main_clk = "gpmc_fck",
> + .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> +};
Is there some reason why you are setting the HWMOD_INIT_NO_RESET flag
here? Seems to me that the kernel should not rely on the bootloader GPMC
configuration, but should use a configuration from the board file or DT.
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
