On Thu, 2012-04-26 at 20:32 -0500, Ricardo Neri wrote: > On 04/24/2012 10:37 PM, Ricardo Neri wrote: > >> Are the defines left in the hdmi_audio_i2s_config something that are IP > >> specific? Are they even used? I'm just wondering why many of the defines > >> are in sound headers, but some are left here. > > Some are specific to the OMAP4 HDMI IP, such as HDMI_AUDIO_I2S_SDx_EN. > > Some others refer to generic I2S concepts (such as > > I2S_SCK_EDGE_FALLING/RISING) but defines are used to configure registers > > and such configuration may be different in other hardware. The defines > > that this patch removes are values that are effectively transmitted to > > the sink and are clearly defined in the relevant standards. Anyways, I > > will look at it further to see if some of them can be removed as well. > > Also, the I2S is the same for most of the supported use-cases, if not > > all of them. Maybe I can remove the unused ones. > > I took at a second look at the hdmi_audio_i2s_config. As they are used > to set IP-specific registers, I think they should be kept. Regarding the > unused defines, they are not too many, do not do harm and let you know > what other config values are available. I would like to keep them. What > do you think? Sounds ok to me. I was just worried that there could be some kind of mixup as only parts of the hdmi_audio_i2s_config were removed. But if the rest are IP specific, I think it's fine. Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
