On Fri, Apr 27, 2012 at 2:09 AM, Kevin Hilman <khilman@xxxxxx> wrote: > NeilBrown <neilb@xxxxxxx> writes: > [...] > > From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001 > From: NeilBrown <neilb@xxxxxxx> > Date: Wed, 25 Apr 2012 13:05:24 +1000 > Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. > > Without an ->irq_set_wake() method in an irq_chip, calls to > enable_irq_wake() will fail. This also causes these interrupts to not > be able to abort suspend (via check_wakeup_irqs() in late suspend.) > > Currently, we don't implement ->irq_set_wake() for INTC interrupts > because they default to be wakeup enabled by setting the GRPSEL bits > in PM init. Even though there is no ->irq_set_wake(), we want > enable_irq_wake() to succeed so these interrupts can abort suspend > when necessary. > > To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC > interrupts which avoids trying to check irq_chip->irq_set_wake() > and failing when it doesn't exist. > > Longer term, we need to implement ->irq_set_wake() for the INTC > which can manage the appropriate GRPSEL bits. > > Signed-off-by: NeilBrown <neilb@xxxxxxx> > [khilman@xxxxxx: rework changelog] > Signed-off-by: Kevin Hilman <khilman@xxxxxx> > --- Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
