NeilBrown <neilb@xxxxxxx> writes: > On Thu, 26 Apr 2012 13:39:07 -0700 Kevin Hilman <khilman@xxxxxx> wrote: > >> NeilBrown <neilb@xxxxxxx> writes: >> >> > All interrupts can wake-from-sleep (I think) so it should be >> > permissible to call enable_irq_wake(). Setting this flag allows that. >> > >> > It is needed because without this, an interrupt which is delivered >> > during late suspend will get ignored but will not cause suspend to >> > abort. >> > If enable_irq_wake() is called and succeeds, check_wakuep_irqs() >> > will abort the suspend if the interrupt has fired. >> > >> > Signed-off-by: NeilBrown <neilb@xxxxxxx> >> >> The name of this flag and the effect of setting it are somewhat >> confusing (e.g. why does skipping set_wake suddenly make wakeups work.) >> So I tried to make it clearer with a reworking of the changelog (below.) >> >> If I understood this correctly, and if you're OK with the updated >> changelog, I'll queue this up for v3.5. >> > > I'm very OK with your updated changelog - thanks. Filling in various bits > that I didn't know and clarifies the rest :-) Great, thanks. Adding ack from Santosh (thanks!) and queuing for v3.5[1] Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/pm-misc -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html