On Tue, Apr 17, 2012 at 00:42:06, DebBarma, Tarun Kanti wrote:
> On Mon, Apr 16, 2012 at 8:33 PM, Hiremath, Vaibhav <hvaibhav@xxxxxx> wrote:
> > On Mon, Apr 16, 2012 at 17:55:24, DebBarma, Tarun Kanti wrote:
> >> We do not use iclk anywhere in the dmtimer driver and so removing it.
> >> Hence removing the timer iclk entries from OMAP4 clkdev table as well.
> >>
> >> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> >> ---
> >> arch/arm/mach-omap2/clock44xx_data.c | 11 -----------
> >> arch/arm/mach-omap2/timer.c | 7 -------
> >> arch/arm/plat-omap/include/plat/dmtimer.h | 2 +-
> >> 3 files changed, 1 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> >> index fa6ea65..2172f66 100644
> >> --- a/arch/arm/mach-omap2/clock44xx_data.c
> >> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> >> @@ -3355,17 +3355,6 @@ static struct omap_clk omap44xx_clks[] = {
<snip>
> >> CLK("omap_i2c.3", "ick", &dummy_ck, CK_443X),
> >> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> >> index c512bac..5d7a0ee 100644
> >> --- a/arch/arm/mach-omap2/timer.c
> >> +++ b/arch/arm/mach-omap2/timer.c
> >> @@ -169,13 +169,6 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
> >> if (IS_ERR(timer->fclk))
> >> return -ENODEV;
> >>
> >> - sprintf(name, "gpt%d_ick", gptimer_id);
> >> - timer->iclk = clk_get(NULL, name);
> >> - if (IS_ERR(timer->iclk)) {
> >> - clk_put(timer->fclk);
> >> - return -ENODEV;
> >> - }
> >> -
> >
> > Doesn't this impact OMAP3x family?
> > The interface clocks will be enabled in omap_hwmod_enable(),
> > only if you set OCPIF_SWSUP_IDLE flag.
> Please note that gptX_ick definitions are still intact in
> clock3xxx_data.c and omap_hwmod_3xxx_data.c.
> At least I have not observed impact of removing this on OMAP3430SDP
> testing.
I guess that could be because, you are not using gptimer for clocksource
and in case of clockevent, the clock must be already enabled by u-boot.
Thanks,
Vaibhav
> --
> Tarun
> >
> > Thanks,
> > Vaibhav
> >
> >> omap_hwmod_enable(oh);
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
