On Mon, Apr 16, 2012 at 10:20 PM, Paul Walmsley <paul@xxxxxxxxx> wrote: > Hi Tarun, > > by the way, > > On Mon, 16 Apr 2012, Tarun Kanti DebBarma wrote: > >> We do not use iclk anywhere in the dmtimer driver and so removing it. >> Hence removing the timer iclk entries from OMAP4 clkdev table as well. >> >> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx> >> --- >> arch/arm/mach-omap2/clock44xx_data.c | 11 ----------- >> arch/arm/mach-omap2/timer.c | 7 ------- >> arch/arm/plat-omap/include/plat/dmtimer.h | 2 +- >> 3 files changed, 1 insertions(+), 19 deletions(-) >> > > ... > >> diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-omap/include/plat/dmtimer.h >> index 9418f00..be2b8c4 100644 >> --- a/arch/arm/plat-omap/include/plat/dmtimer.h >> +++ b/arch/arm/plat-omap/include/plat/dmtimer.h >> @@ -259,7 +259,7 @@ struct omap_dm_timer { >> unsigned long phys_base; >> int id; >> int irq; >> - struct clk *iclk, *fclk; >> + struct clk *fclk; >> >> void __iomem *io_base; >> void __iomem *sys_stat; /* TISTAT timer status */ > > Am dropping this stray change, it seems unrelated to the rest of the > patch. Since the only usage of timer->iclk is removed from mach-omap2/timer.c there is no point in keeping this field in struct omap_dm_timer {}. Unless you are suggesting that both the above should be separated into a separate patch? -- Tarun > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html