RE: [PATCH 2/3] ARM: OMAP2+: dmtimer: cleanup iclk usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 16, 2012 at 17:55:24, DebBarma, Tarun Kanti wrote:
> We do not use iclk anywhere in the dmtimer driver and so removing it.
> Hence removing the timer iclk entries from OMAP4 clkdev table as well.
> 
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> ---
>  arch/arm/mach-omap2/clock44xx_data.c      |   11 -----------
>  arch/arm/mach-omap2/timer.c               |    7 -------
>  arch/arm/plat-omap/include/plat/dmtimer.h |    2 +-
>  3 files changed, 1 insertions(+), 19 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> index fa6ea65..2172f66 100644
> --- a/arch/arm/mach-omap2/clock44xx_data.c
> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> @@ -3355,17 +3355,6 @@ static struct omap_clk omap44xx_clks[] = {
>  	CLK(NULL,	"auxclk5_ck",			&auxclk5_ck,	CK_443X),
>  	CLK(NULL,	"auxclkreq5_ck",		&auxclkreq5_ck,	CK_443X),
>  	CLK(NULL,	"gpmc_ck",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt1_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt2_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt3_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt4_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt5_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt6_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt7_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt8_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt9_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt10_ick",			&dummy_ck,	CK_443X),
> -	CLK(NULL,	"gpt11_ick",			&dummy_ck,	CK_443X),
>  	CLK("omap_i2c.1",	"ick",				&dummy_ck,	CK_443X),
>  	CLK("omap_i2c.2",	"ick",				&dummy_ck,	CK_443X),
>  	CLK("omap_i2c.3",	"ick",				&dummy_ck,	CK_443X),
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index c512bac..5d7a0ee 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -169,13 +169,6 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
>  	if (IS_ERR(timer->fclk))
>  		return -ENODEV;
>  
> -	sprintf(name, "gpt%d_ick", gptimer_id);
> -	timer->iclk = clk_get(NULL, name);
> -	if (IS_ERR(timer->iclk)) {
> -		clk_put(timer->fclk);
> -		return -ENODEV;
> -	}
> -

Doesn't this impact OMAP3x family?
The interface clocks will be enabled in omap_hwmod_enable(), 
only if you set OCPIF_SWSUP_IDLE flag.

Thanks,
Vaibhav

>  	omap_hwmod_enable(oh);

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux