Re: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kevin,

On Tuesday 28 February 2012 05:58 AM, Kevin Hilman wrote:
Tero Kristo<t-kristo@xxxxxx>  writes:

From: Rajendra Nayak<rnayak@xxxxxx>

With no driver handling DSP/TESLA, if brought out of reset, it stays
active and does not assert standby.

Signed-off-by: Rajendra Nayak<rnayak@xxxxxx>
Signed-off-by: Tero Kristo<t-kristo@xxxxxx>

Subject says 'OMAP4: suspend'.  How does HWMOD_INIT_NO_RESET affect
suspend?

The v2 of this patch posted by Tero has a better $subject as suggested
by Benoit which says 'ARM: OMAP4: hwmod_data: Do not get DSP out of
reset at boot time'

The intention of this patch is to *not* get DSP out of reset at boot,
because once out of reset DSP needs some code that executes a 'wfi'
equivalent for it to assert a standby and allow suspend to sleep.

regards,
Rajendra


Kevin

---
  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index ef0524c..81d90da 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -1160,6 +1160,7 @@ static struct omap_hwmod omap44xx_dsp_hwmod = {
  	.name		= "dsp",
  	.class		=&omap44xx_dsp_hwmod_class,
  	.clkdm_name	= "tesla_clkdm",
+	.flags		= HWMOD_INIT_NO_RESET,
  	.mpu_irqs	= omap44xx_dsp_irqs,
  	.rst_lines	= omap44xx_dsp_resets,
  	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_dsp_resets),

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux