On Tue, Feb 28, 2012 at 5:32 AM, Kevin Hilman <khilman@xxxxxx> wrote: > Tarun Kanti DebBarma <tarun.kanti@xxxxxx> writes: > >> This local variable is just assigned zero and then OR'ed >> with isr. It does not appear to serve any purpose and so >> removing it. >> >> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx> > > Looks like the use of this was removed when I moved things over to using > the generic IRQ framework, but I didn't fully clean up. > > Can you update the changelog to something along the lines of: > > "commit 672e302e3c (ARM: OMAP: use edge/level handlers from generic IRQ > framework) removed retrigger support in favor of using generic IRQ > framework. This patch cleans up some unused remnants of that removal. Yes, sure. -- Tarun > > Thanks, > > Kevin > >> --- >> drivers/gpio/gpio-omap.c | 3 --- >> 1 files changed, 0 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c >> index b62e861..3dd4b3a 100644 >> --- a/drivers/gpio/gpio-omap.c >> +++ b/drivers/gpio/gpio-omap.c >> @@ -623,7 +623,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) >> u32 isr; >> unsigned int gpio_irq, gpio_index; >> struct gpio_bank *bank; >> - u32 retrigger = 0; >> int unmasked = 0; >> struct irq_chip *chip = irq_desc_get_chip(desc); >> >> @@ -660,8 +659,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) >> chained_irq_exit(chip, desc); >> } >> >> - isr |= retrigger; >> - retrigger = 0; >> if (!isr) >> break; -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
